TeamCity: add Ephemeral-write-only subproject #12538

BBBmau · 2024-12-10T20:58:48Z

Note

This will be marked as Ready for Review once we have a 1.11 TF alpha version ready

Marking Ready for Review with the release of v1.11.0-alpha20241211

This project is meant to be used for testing Write-Only attributes on resources that will support it in Terraform 1.11

It will do the following:

Use the latest 1.11 TF Version
Run builds on services that will have resources that use write-only attributes
Have builds that use modular-magician / HC owned repos
CRON triggers to schedule builds on hc repos

Here's a preview of the changes

How Triggers are set

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

modular-magician · 2024-12-10T21:09:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 209 insertions(+))

modular-magician · 2024-12-11T06:51:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 245 insertions(+))

modular-magician · 2024-12-17T02:51:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 245 insertions(+))

modular-magician · 2024-12-17T04:43:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 162 insertions(+))

modular-magician · 2024-12-17T04:52:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 217 insertions(+))

modular-magician · 2024-12-17T05:05:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 218 insertions(+))

SarahFrench

👋🏻 Hey, here's some comments but I'm happy to approve this PR after they're resolved (either via discussion only or via code changes we identify to make).

mmv1/third_party/terraform/.teamcity/components/get_services.kt

SarahFrench · 2024-12-17T14:10:39Z

...raform/.teamcity/components/projects/feature_branches/FEATURE-BRANCH-ephemeral-write-only.kt

+    // These are the packages that have resources that will use write-only attributes
+    var ServicesListWriteOnlyGA = getServicesList(arrayOf("compute", "secretmanager", "sql", "bigquerydatatransfer"), "GA")


Good to see that the new project will be limited to only the necessary services! 🙌🏻 Though the Compute build is one of our longest running builds... so running those tests in the feature branch testing project as well as the nightlies could cause some issues.

That's something to keep an eye on, at least. You could even add services to this list progressively over time, instead of adding them all now, to limit impact. Or you could change the trigger time (see other comment)

There was also the idea of changing the test prefix within the write-only subproject to only run Tests with TestAccEphemeral_ though we would miss out on making sure all other tests aren't affected.

I could ensure that all other tests pass by manually triggering them to run the suite entirely, I'm leaning towards this in order to not have to make any TC updates in the future such as including it as part of the getServices list.

That sounds good to me, as long as you're aware there's a potential problem and you've got options about how to navigate it then I'm good 👍🏻

SarahFrench · 2024-12-17T14:12:02Z

...raform/.teamcity/components/projects/feature_branches/FEATURE-BRANCH-ephemeral-write-only.kt

+    val trigger  = NightlyTriggerConfiguration(
+        branch = "refs/heads/$featureBranchEphemeralWriteOnly" // triggered builds must test the feature branch
+    )


Please see other comment about conflicting with the nightly tests, particularly for Compute.

To mitigate this, you could update the trigger in the feature branch test project to run on a later schedule versus the nightlies. E.g. default time + 6 hours

modular-magician · 2024-12-17T17:05:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 163 insertions(+))

modular-magician · 2024-12-17T17:08:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 163 insertions(+))

modular-magician · 2024-12-17T17:28:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 163 insertions(+))

modular-magician · 2024-12-17T17:35:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 219 insertions(+))

BBBmau · 2024-12-17T18:55:44Z

although this was approved, it could use a quick PR check since I introduced support for custom test prefix.

Currently this will only run tests with the regex TestAcc.*Ephemeral with the default value being TestAcc if unset.

@SarahFrench

This can be ignored after seeing #12538 (comment)

modular-magician · 2024-12-17T18:58:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 226 insertions(+), 6 deletions(-))

add Ephemeral-write-only subproject into teamcity

64fa030

fix teamcity config

ea46802

BBBmau changed the title ~~add Ephemeral-write-only subproject into teamcity~~ TeamCity: add Ephemeral-write-only subproject Dec 11, 2024

use 1.11 alpha

d909d01

BBBmau marked this pull request as ready for review December 17, 2024 02:45

BBBmau added 2 commits December 16, 2024 20:33

rewrite to use getServices

dadf0d3

add getServices.kt

e800475

root_project add

cc29570

BBBmau requested a review from SarahFrench December 17, 2024 05:13

SarahFrench reviewed Dec 17, 2024

View reviewed changes

BBBmau force-pushed the add-ephemeral-write-only-tc branch from 83bae16 to 0ce1327 Compare December 17, 2024 16:58

BBBmau force-pushed the add-ephemeral-write-only-tc branch from 0ce1327 to 519e6be Compare December 17, 2024 17:18

remove unneccessary transformation of paths in get_services.kt

18aa211

BBBmau force-pushed the add-ephemeral-write-only-tc branch from 519e6be to 18aa211 Compare December 17, 2024 17:25

SarahFrench approved these changes Dec 17, 2024

View reviewed changes

add startHour and support for custom testprefix in buildConfigurations

aba9b89

BBBmau merged commit a560147 into GoogleCloudPlatform:main Dec 17, 2024
12 checks passed

modular-magician mentioned this pull request Dec 17, 2024

TeamCity: add Ephemeral-write-only subproject hashicorp/terraform-provider-google-beta#8931

Merged

This was referenced Dec 17, 2024

TeamCity: add Ephemeral-write-only subproject hashicorp/terraform-provider-google#20722

Merged

TeamCity: add Ephemeral-write-only subproject GoogleCloudPlatform/terraform-google-conversion#3224

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TeamCity: add Ephemeral-write-only subproject #12538

TeamCity: add Ephemeral-write-only subproject #12538

BBBmau commented Dec 10, 2024 •

edited

Loading

modular-magician commented Dec 10, 2024

modular-magician commented Dec 11, 2024

modular-magician commented Dec 17, 2024

modular-magician commented Dec 17, 2024

modular-magician commented Dec 17, 2024

modular-magician commented Dec 17, 2024

SarahFrench left a comment

SarahFrench Dec 17, 2024

BBBmau Dec 17, 2024

SarahFrench Dec 17, 2024

SarahFrench Dec 17, 2024

modular-magician commented Dec 17, 2024

modular-magician commented Dec 17, 2024

modular-magician commented Dec 17, 2024

modular-magician commented Dec 17, 2024

BBBmau commented Dec 17, 2024 •

edited

Loading

modular-magician commented Dec 17, 2024

		// These are the packages that have resources that will use write-only attributes
		var ServicesListWriteOnlyGA = getServicesList(arrayOf("compute", "secretmanager", "sql", "bigquerydatatransfer"), "GA")

TeamCity: add Ephemeral-write-only subproject #12538

TeamCity: add Ephemeral-write-only subproject #12538

Conversation

BBBmau commented Dec 10, 2024 • edited Loading

Here's a preview of the changes

How Triggers are set

modular-magician commented Dec 10, 2024

Diff report

modular-magician commented Dec 11, 2024

Diff report

modular-magician commented Dec 17, 2024

Diff report

modular-magician commented Dec 17, 2024

Diff report

modular-magician commented Dec 17, 2024

Diff report

modular-magician commented Dec 17, 2024

Diff report

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench Dec 17, 2024

Choose a reason for hiding this comment

BBBmau Dec 17, 2024

Choose a reason for hiding this comment

SarahFrench Dec 17, 2024

Choose a reason for hiding this comment

SarahFrench Dec 17, 2024

Choose a reason for hiding this comment

modular-magician commented Dec 17, 2024

Diff report

modular-magician commented Dec 17, 2024

Diff report

modular-magician commented Dec 17, 2024

Diff report

modular-magician commented Dec 17, 2024

Diff report

BBBmau commented Dec 17, 2024 • edited Loading

modular-magician commented Dec 17, 2024

Diff report

BBBmau commented Dec 10, 2024 •

edited

Loading

BBBmau commented Dec 17, 2024 •

edited

Loading